search

cisagov / CHIRP

A DFIR tool written in Python.
Creative Commons Zero v1.0 Universal
1.04k stars 90 forks source link

Program freezes after scan complete #8

Closed DeemOnSecurity closed 3 years ago

DeemOnSecurity commented 3 years ago

🐛 Summary

CHIRP should print it has completed then runs input() to hold the window until a user presses another button, however the process hangs after all scans have completed.

To reproduce

Steps to reproduce the behavior:

  1. Run chirp.exe

Expected behavior

CHIRP should only hang until a key is pressed.

Any helpful log output or screenshots

Add any screenshots of the problem here. image

DASCert commented 3 years ago

"Expected behavior" CHIRP should only hang until a key is pressed.??

Really? If the purpose is to hold the window open, assuming that someone double-clicked the exe to run it, a "process complete, press any key to close" message would be nice, As it is, the process hangs before it actually complete (see Issue #10)

DeemOnSecurity commented 3 years ago

"Expected behavior" CHIRP should only hang until a key is pressed.??

Really? If the purpose is to hold the window open, assuming that someone double-clicked the exe to run it, a "process complete, press any key to close" message would be nice, As it is, the process hangs before it actually complete (see Issue #10)

In the case of issue #10, the process never completed as an exception was thrown by the events plugin on the main process. The extra workers running were still running the yara scan.

You're right that we should consider adding the "Press Any Key" verbiage to the done message, but we still need to figure out how to get it to quit once a key is pressed or it's a moot point 😄.

DeemOnSecurity commented 3 years ago

Resolved by #12