The linter workflow was configured to always pass despite any relevant warnings found. There have been situations where code that did not meet the linter's standards were merged into main. The placement of continue-on-error has been updated so the workflow catches relevant errors.
All PowerShell warnings have been addressed except for two files which call Invoke-Expression. The change is trivial but requires additional testing of SetupTestbed.ps1/install_lme.ps1 which is out of scope for this PR. See the issue below for more info.
💭 Motivation and context
Improves our CI/CD integrations and overall testing of LME.
Resolves #175
Additional todos after this PR is merged:
327
328
🧪 Testing
Ran the main.yml Github action, checked warnings/errors from PSScriptAnalyzer and applied necessary changes.
✅ Pre-approval checklist
[x] Changes are limited to a single goal AND
the title reflects this in a clear human readable format
[x] Issue that this PR solves has been selected in the Development section
[x] I have read and agree to LME's CONTRIBUTING.md document.
[x] The PR adheres to LME's requirements in RELEASES.md
🗣 Description
The linter workflow was configured to always pass despite any relevant warnings found. There have been situations where code that did not meet the linter's standards were merged into main. The placement of
continue-on-errorhas been updated so the workflow catches relevant errors.All PowerShell warnings have been addressed except for two files which call Invoke-Expression. The change is trivial but requires additional testing of SetupTestbed.ps1/install_lme.ps1 which is out of scope for this PR. See the issue below for more info.
💭 Motivation and context
Improves our CI/CD integrations and overall testing of LME.
Resolves #175
Additional todos after this PR is merged:
327
328
🧪 Testing
Ran the main.yml Github action, checked warnings/errors from PSScriptAnalyzer and applied necessary changes.
✅ Pre-approval checklist
✅ Pre-merge Checklist
✅ Post-merge Checklist