Change pcap file upload logging to be more descriptive.

[Hashfastr]

🗣 Description

Changing error log for file upload when there's an invalid file type uploaded. Previously just printed a single trashcan emoji (🗑️), changed to be more descriptive.

💭 Motivation and context

When debugging why I couldn't upload a PCAP file to Malcolm I kept getting the below error.

WARNING: watch-pcap-uploads-folder.py:  🗑   /pcap/upload/AUTOSURICATA,AUTOZEEK,all,cloud,azure,USERTAG,cloud.pcapng (application/octet-stream/pcapng capture file - version 1.0)

This is minimally descriptive only providing a trashcan emoji along with the file name and mime type. The message can be assumed that your submitted file was immediately deleted. While the attached filename and mime type seems much more descriptive of what was uploaded, but not to why the error occurred.

This pull request changed this single line error to two much more descriptive errors:

ERROR: watch-pcap-uploads-folder.py: Invalid file type uploaded application/octet-stream/pcapng capture file - version 1.0
ERROR: watch-pcap-uploads-folder.py: Deleting /pcap/upload/AUTOSURICATA,AUTOZEEK,all,cloud,azure,USERTAG,cloud.pcapng

While I like the flair emojis give scripts, putting them into error logs is a misstep and either further obfuscates the error at hand, or makes it much more difficult to parse.

🧪 Testing

Splits one print statement into two, removes an emoji, don't really think this applies.

✅ Pre-approval checklist

• [x] This PR has an informative and human-readable title.
• [x] Changes are limited to a single goal - eschew scope creep!
• [ ] All relevant type-of-change labels have been added.
• [x] I have read the CONTRIBUTING document.
• [x] These code changes follow cisagov code standards.
• [x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge checklist

• [ ] Revert dependencies to default branches.
• [ ] Finalize version.

✅ Post-merge checklist

• [ ] Create a release.

[Hashfastr]

Unsure of labels or how to add them at the moment seeing it's greyed out for me.

[mmguero]

Thanks for the suggestion! There is a reason for the emojis: sometimes when I'm developing/debugging artifact processing I'm looking at hundreds or thousands of files, and they're zipping by in the logs quickly. Those icons (which I use across many of the internal malcolm scripts) make it easier to visually identify the operation at a glance.

But I do agree that in this case the message needs to be more helpful to the end user as well. I think I will probably retain the icon but also add a more descriptive error message as you suggested.