When navigating to a row of a scrolling list (like a command), we want to apply some kind of visual indicator of the target. This is traditionally styled with the :target pseudo selector when navigating to an internal anchor link. We are implementing it differently but the concept is the same
Added UtilityStyle.scrollTarget
implemented UtilityStyle.scrollTarget on:
RawLogs lines
Command InfoRows - scrollTarget is added and then removed by the scrollToCommand method
InfoRows generally via the scrollTarget prop
TODOs
[x] Implement this on Comments (Later PR)
Clicking a comment from the search dialog won't navigate to it. It should, and it should apply the target style
[x] Maintain scroll position between navigation including back button (Later PR)
Description
When navigating to a row of a scrolling list (like a command), we want to apply some kind of visual indicator of the target. This is traditionally styled with the
:target
pseudo selector when navigating to an internal anchor link. We are implementing it differently but the concept is the sameUtilityStyle.scrollTarget
UtilityStyle.scrollTarget
on:InfoRow
s -scrollTarget
is added and then removed by thescrollToCommand
methodInfoRow
s generally via thescrollTarget
propTODOs
Testing
Screenshots