Refactor AAD Unit test to pull from central Jsons

Sloane4 commented 3 months ago

🗣 Description

Create central Jsons configs that can be pulled and modified slightly for each unit test Closing #1113 Closing #1175

💭 Motivation and context

Reduce copy and paste errors and file size. Reduce the difficulty of writing unit tests and PRs. In the process of refactor, discovered false passing in unit tests, adding fix as closely related

🧪 Testing

[x] All AAD unit tests pass
[x] Unit tests that are discovered to have bugs are skipped and have relevant GitHub issues
[x] Unit tests utilize test assertions for debugging
[x] RunUnitTests.ps1 passes all the new utility files

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!
[x] Changes are sized such that they do not touch excessive number of files.
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] These code changes follow the ScubaGear content style guide.
[x] Related issues these changes resolve are linked preferably via closing keywords.
[x] All relevant type-of-change labels added.
[x] All relevant project fields are set.
[x] All relevant repo and/or project documentation updated to reflect these changes.
[x] Unit tests added/updated to cover PowerShell and Rego changes.
[x] Functional tests added/updated to cover PowerShell and Rego changes.
[x] All relevant functional tests passed.
[x] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[x] PR passed smoke test check.
[x] Feature branch has been rebased against changes from parent branch, as needed

Use Rebase branch button below or use this reference to rebase from the command line.
[x] Resolved all merge conflicts on branch
[x] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

schrolla commented 3 months ago

@Sloane4 Looks like the smoke test is having trouble access the new assert functions and failing.

Sloane4 commented 3 months ago

@Sloane4 Looks like the smoke test is having trouble access the new assert functions and failing.

@schrolla fixed

Sloane4 commented 3 months ago

@nanda-katikaneni ready for merge

cisagov / ScubaGear