cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
1.6k stars 215 forks source link

Bump azure/login action to v2 #1152

Closed schrolla closed 3 months ago

schrolla commented 3 months ago

πŸ—£ Description

The azure/login GitHub action allows our publishing workflows to access our code signing certificate from an Azure Key Vault. However, GitHub has deprecated azure/login@v1 due to the end of life of Node.js v16 used by this action. The newer @v2 uses the supported Node.js v20 software and resolves the login issue in our workflows.

πŸ’­ Motivation and context

The publish workflows that use the azure/login action are failing as the previous version is now deprecated and causing it the login to fail on execution. Upgrading the action to the latest (v2) resolves the issue. Closes #1049

πŸ§ͺ Testing

Review the most recent failed Publish and sign Draft Release and Publish public package action results to see the issue and note the deprecation warning.

See successful results of Build and Sign Release workflow on this branch here: https://github.com/cisagov/ScubaGear/actions/runs/9407521339/job/25913440630

βœ… Pre-approval checklist

βœ… Pre-merge checklist

βœ… Post-merge checklist

schrolla commented 3 months ago

@nanda-katikaneni Ready for merge.