cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
1.44k stars 203 forks source link

Fix repo targetting bug in private publish workflow #1155

Open schrolla opened 3 weeks ago

schrolla commented 3 weeks ago

🐛 Summary

The GitHub workflow titled "Publish Private Package" defined in .github/workflows/publish_private_package.yaml fails on its final self check if, when installing the published module, there is a ScubaGear module in the public PSGallery module as well.

The issue appears to be that the public PSGallery is not removed from the set of package sources and/or the Install-Module command is not given the -Repository flag set to the private repository source. Recommend the latter as a fix.

To reproduce

Steps to reproduce the behavior:

  1. Run the workflow
  2. Then review the errors (see screenshot for example)

Expected behavior

I expected the self test to target the private package repository, specifically, so that it would install only the test ScubaGear module.

Any helpful log output or screenshots

Screenshot showing the failure: Screenshot 2024-06-07 at 3 02 16 PM