cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
1.44k stars 203 forks source link

This PR is one fix of many for Refactor EXO Unit Tests #1111 And other problems with unit tests. One fix for all. #1162

Open bosesubham2011 opened 2 weeks ago

bosesubham2011 commented 2 weeks ago

Hey Community,

As I am only few hours old of being contributing to open-source. Please provide feedback. I WANT to write unit tests, integration tests for ALL modules of this repo. This PR is one of many.

๐Ÿ—ฃ Description

Introduces pester for PowerShell unit testing.

๐Ÿ’ญ Motivation and context

This fixes all issues around Unit tests. I can take up any issue, if someone reaches out.

๐Ÿงช Testing

Locally ran and tested the changes. You need to have pester downloaded or added to this repo.

๐Ÿ“ท Screenshots (if appropriate)

Uncomment this section if a screenshot is needed.

-->

โœ… Pre-approval checklist

โœ… Pre-merge checklist

โœ… Post-merge checklist

bosesubham2011 commented 2 weeks ago

If this PR is checked and feedback is received, I am ready to take up testing of all the modules. First complete all unit tests Integrate with pipeline, so that they are ran at buid time More discussions to understand the internal flow, so that Mock functions can be written

Integration tests: This will be the 2nd step After unit tests are written, we will have a clear understanding of how the functions are behaving This will also help us fetch any integration between said functions tests will be written accordingly in Pester.

adhilto commented 2 weeks ago

Hi, thanks for your contribution! We will review this when we can, though I'm not sure what our timeline looks like, as we currently have over 15 PRs in review. Stay tuned for now.

bosesubham2011 commented 2 weeks ago

Thanks for your comment. Please take your time, no rush!