Closed julianjburgos closed 1 day ago
Is there a reason this is labelled as both a bug and enhancement? The source issue is listed as an enhancement even though it was filed as if it was a bug report. As a recall, the answer was that when exclusions were added they were added to specific policy items to support things like break glass accounts. Other checks (that didn't exist or weren't relevant to that) didn't get the exclusions. So, while it might have not met some expectations, it was working as expected by the developers who created it and not a bug. So I would recommend labeling related items as enhancements only.
Is there a reason this is labelled as both a bug and enhancement? The source issue is listed as an enhancement even though it was filed as if it was a bug report. As a recall, the answer was that when exclusions were added they were added to specific policy items to support things like break glass accounts. Other checks (that didn't exist or weren't relevant to that) didn't get the exclusions. So, while it might have not met some expectations, it was working as expected by the developers who created it and not a bug. So I would recommend labeling related items as enhancements only.
Updated to only enhancement
New PR created to address this item.
๐ฃ Description
Added user exclusions and group exclusions to AAD 3.7. Closes #988
๐ญ Motivation and context
The Rego code for AAD is missing the user and group exclusions
Actions:
๐งช Testing
Run AAD against all tenants and check that 3.7 supports exclusions like other policies.
โ Pre-approval checklist
โ Pre-merge checklist
[ ] Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.โ Post-merge checklist