cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
1.44k stars 203 forks source link

Add policy check for AAD 3.7 to support exclusions #1163

Closed julianjburgos closed 1 day ago

julianjburgos commented 2 weeks ago

๐Ÿ—ฃ Description

Added user exclusions and group exclusions to AAD 3.7. Closes #988

๐Ÿ’ญ Motivation and context

The Rego code for AAD is missing the user and group exclusions

Actions:

๐Ÿงช Testing

Run AAD against all tenants and check that 3.7 supports exclusions like other policies.

โœ… Pre-approval checklist

โœ… Pre-merge checklist

โœ… Post-merge checklist

schrolla commented 2 weeks ago

Is there a reason this is labelled as both a bug and enhancement? The source issue is listed as an enhancement even though it was filed as if it was a bug report. As a recall, the answer was that when exclusions were added they were added to specific policy items to support things like break glass accounts. Other checks (that didn't exist or weren't relevant to that) didn't get the exclusions. So, while it might have not met some expectations, it was working as expected by the developers who created it and not a bug. So I would recommend labeling related items as enhancements only.

dagarwal-mitre commented 2 weeks ago

Is there a reason this is labelled as both a bug and enhancement? The source issue is listed as an enhancement even though it was filed as if it was a bug report. As a recall, the answer was that when exclusions were added they were added to specific policy items to support things like break glass accounts. Other checks (that didn't exist or weren't relevant to that) didn't get the exclusions. So, while it might have not met some expectations, it was working as expected by the developers who created it and not a bug. So I would recommend labeling related items as enhancements only.

Updated to only enhancement

schrolla commented 1 day ago

New PR created to address this item.