search

cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
1.6k stars 215 forks source link

Update run_module_version_bump.yml to include psgallery.md #1183

Open mitchelbaker-cisa opened 3 months ago

mitchelbaker-cisa commented 3 months ago

🐛 Summary

In psgallery.md we reference version 1.2.0, run_module_version_bump.yml should be updated to auto adjust to the latest version number here as well.

Screenshot (109)

Expected behavior

run_module_version_bump.yml workflow should parse psgallery.md and auto adjust any references of the semver release number to the latest ScubaGear version.

mitchelbaker-cisa commented 3 months ago

Also noticed run_module_version_bump.yml updates the zip file name as ScubaGear-v1-3-0.zip instead of ScubaGear-v1.3.0.zip. Screenshot (111)

On line 54 we use the -replace operator to switch out all '\.' with '-', @buidav was this done because of escape handling? Screenshot (113)

buidav commented 3 months ago

On line 54 we use the -replace operator to switch out all '.' with '-', @buidav was this done because of escape handling? !

No 🤦 <= me. Looks I overlooked the change from - to . in the release package name for over a year now. Something else to fix.

schrolla commented 2 months ago

@buidav I've already run the existing bump for this release cycle and manually updated that PR to address the items caught by this issue. So we can bump this back to Jellyfish if need be.