cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines

https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project

Creative Commons Zero v1.0 Universal

1.44k stars 203 forks source link

Fix the OPA version bump workflow to work with the new README #1187

Closed buidav closed 18 hours ago

buidav commented 4 days ago

🐛 Summary

The OPA version bump workflow used to regularly bump the OPA version is currently erroring out do to the README changes. This issue

To reproduce

View the errors in the latest OPA version bump workflows.

Expected behavior

For the workflows to bump the versions without any errors.

schrolla commented 4 days ago

This is part of #1133 which was put in as a known issue resulting from the updated documentation. Currently planned to be worked in the upcoming sprint 2.

buidav commented 4 days ago

This is part of #1133 which was put in as a known issue resulting from the updated documentation. Currently planned to be worked in the upcoming sprint 2.

That issue is more for the ScubaGear version right? That will be a need little more code to fix that this issue :).

james-garriss commented 2 days ago

I think the real solution to this sort of problem is related to the "we don't have all of our static requirements in one constants/config file" problem that other issues have brought up. IOW, this isn't a uniquely OPA problem. The README also talks about the names/versions of the PS modules that are installed. We should solve the problem one time, one way for everything, instead of piece-mealing it.