cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
1.65k stars 221 forks source link

Ensure functional testing is stable and reliable #1209

Open schrolla opened 3 months ago

schrolla commented 3 months ago

💡 Summary

Functional testing is built to be an automated process to quickly and regularly validate that ScubaGear functions as intended. Currently, some of the functional tests are failing regularly which impedes the value of those tests. This epic is meant to collect these issues to support fixes that improve functional test stability (Defender) and possibly coverage (SPO module).

Motivation and context

Automated functional testing saves developers time and improves the overall quality of the ScubaGear tool. Making functional tests more reliable and increasing their coverage will further increase code quality.

Implementation notes

Please provide details for implementation, such as:

Acceptance criteria

The following issues are completed

gdasher commented 2 months ago

It also looks like the smoke tests need a once over. In particular, the markdown tests reference the wrong location for the baselines and fail on baseline update changes:

Testing/Functional/MarkdownChecks/ValidateMarkdowns.Tests.ps1

james-garriss commented 2 months ago

Ok, but they are distinct from the functional tests, so this problem would not be part of this epic. I will make sure that a new issue is created for the smoke tests.