cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
1.59k stars 215 forks source link

Update SharePoint policies 1.3 with less verbose language #1308

Open mitchelbaker-cisa opened 3 weeks ago

mitchelbaker-cisa commented 3 weeks ago

🐛 Summary

MS.SHAREPOINT.1.3v1 and MS.SHAREPOINT.1.4v1 contains the following note:

"is set to any value other than" is verbose language and makes the policy instructions confusing.

The note should be updated with a negation to be more clear:

Expected behavior

  1. Update policy with clear language
  2. Update the NAString() method and all instances where its used to reflect the updated language.

Screenshot (206)

mitchelbaker-cisa commented 4 days ago

https://github.com/cisagov/ScubaGear/pull/1309 made the code changes for this issue, SharePoint 1.3 details now displays:

This policy is only applicable if the external sharing slider on the admin page is not set to Only People In Your Organization. See Secure Configuration Baseline policy for more info

Now this issue only requires the baseline change to be made.