cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
1.61k stars 218 forks source link

determine if additional functional or unit tests are needed for Entra Id provider Get-PrivilegedUser #1340

Open tkol2022 opened 2 weeks ago

tkol2022 commented 2 weeks ago

💡 Summary

The Entra Id provider script has incorporated some complex logic over time and in order to continuously test the scenarios that were coded, we need an automated repeatable mechanism. In particular the Get-PrivilegedUser function and the recursive LoadObjectDataIntoPrivilegedUserHashtable function. For the most recent PR #1310 I had to concoct and document some multi-step scenarios for manual testing by PR reviewers. Those take careful setup in the tenant and an eye for detail on the part of the reviewer, plus they require manual labor.

The scope of this issue is to examine the code, determine which test scenarios need long-term automated test cases, and then determine how to codify those tests which will require some creative solutions given the constraints involved with manipulating the tenant to set up the objects needed. We also have some automated unit tests that exercise the

Implementation notes

tkol2022 commented 2 weeks ago

@nanda-katikaneni @mitchelbaker-cisa See if you want to team up on this since you recently tested some related scenarios.