search

cisagov / ScubaGear

Automation to assess the state of your M365 tenant against CISA's baselines
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
1.77k stars 228 forks source link

Certificate error due to broken url #1421

Open ahuynhMITRE opened 1 week ago

ahuynhMITRE commented 1 week ago

💡 Summary

leftover error from issue #1341 in order to push the SCB Markdown fixes first.

The following links are broken:

 {'location': '/PowerShell/ScubaGear/Testing/Unit/PowerShell/CreateReport/CreateReportStubs/aad.md:204',
  'url': 'https://playbooks.idmanagement.gov/piv/network/group/'}]

Motivation and context

We don't want our users to run into errors from our documentation.

Implementation notes

The broken link shown above gives a certificate error. The last one isn't user facing so is less important, but if we were ever to add the capability to validate the markdown links to the CI/CD pipeline (something I'm exploring right now), it would be worth correcting.

Acceptance criteria

schrolla commented 8 hours ago

Correct link in the AAD markdown for reference.

schrolla commented 8 hours ago

See https://github.com/cisagov/ScubaGoggles/issues/352 as dependent issue. Complete this issue prior to implementing auto link checking,