search

cisagov / ScubaGoggles

SCuBA Security Configuration Baselines and assessment tool for Google Workspace
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
129 stars 13 forks source link

Common Controls 12.1v1 is being duplicated in the report #237

Closed buidav closed 3 months ago

buidav commented 3 months ago

🐛 Summary

Common Controls 12.1v1 is being duplicated in the report. Not sure what the reason for this is.

To reproduce

Steps to reproduce the behavior:

Run ScubaGoggles on the main branch with commoncontrols as a baseline selected.

Expected behavior

Only a single instance of 12.1 is being displayed

Any helpful log output or screenshots

CommonControls
adhilto commented 3 months ago

This is actually by-design, though I'm sure there's a better way we could have done it.

image

The first row in the report corresponds to the arrow at the top, i.e., "Currently unable to check that Google takeout is disabled for services without..", which for some reason doesn't produce a log event.

The second row corresponds to "apps with individual admin control[s]," which do produce a logs event.

adhilto commented 3 months ago

EDIT: I just checked. While what I said was once upon a time true, the top part does produce a log event now. So I would recommend implementing a check for that and combining the output of those two rows into a single row.

image