cisagov / ScubaGoggles

SCuBA Security Configuration Baselines and assessment tool for Google Workspace

https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project

Creative Commons Zero v1.0 Universal

129 stars 13 forks source link

Baseline report details are inconsistent #247

Open mitchelbaker-cisa opened 3 months ago

mitchelbaker-cisa commented 3 months ago

🐛 Summary

In orchestrator.py, generate_summary() conditionally shows warnings, failures, and manual checks. Should the same apply for pass summaries?

Screenshot (65)_LI

To reproduce

Steps to reproduce the behavior:

Generate a report from scubagws.org

Expected behavior

The user should not see "0 tests pass" since this is redundant. Omit it from the baseline report details.

buidav commented 3 months ago

@mitchelbaker-cisa The small humorous detail about this question is that since Goggles is a port of ScubaGear, the logic that causes this to happen is actually the same in both. 😂

@adhilto Do you remember the rationale behind this?

ScubaGoggles Orchestrator.py

ScubaGear Orchestrator.psm1

adhilto commented 3 months ago

I think the "passed" column always being displayed is just an artifact of the way we happened to code it; I don't think it was by-design. I certainly wouldn't object to having it only display when applicable.