Max super admin change per issue 252

jkaufman-mitre commented 3 months ago

🗣 Description

Changed the max number of Super Admin accounts from 4 to 8 in order to be consistent with the Microsoft baseline policy.

Fixes #252

💭 Motivation and context

Comment from SNL recommending to be consistent with Microsoft.

🧪 Testing

✅ Pre-approval checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
[ ] The relevant issues PR resolves are linked preferably via closing keywords.
[ ] All relevant type-of-change labels have been added.
[ ] I have read and agree to the CONTRIBUTING.md document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge Checklist

[ ] This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
[ ] Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

[ ] Delete the branch to clean up.
[ ] Close issues resolved by this PR if the closing keywords did not activate.

LaurenBassett commented 1 month ago

This feels like it has expanded FAR beyond what is outlined in the title. Can we update the title of the PR and description to inform what we should be looking for here?

adhilto commented 1 month ago

This feels like it has expanded FAR beyond what is outlined in the title. Can we update the title of the PR and description to inform what we should be looking for here?

I think what we're seeing is due to all the baseline changes that have been merged to main after this PR was made. Honestly, if that's what's going on, since there so many changes have been made since this PR was submitted, it would probably be easiest to close this PR and open a new one, rather than try to resolve all the merge conflicts.

EDIT: I tried changing to target branch from main then back to main, because sometimes that helps clean up the presentation on GitHub, but it didn't help this time.

mdueltgen commented 1 month ago

Going to close and reopen to try and fix as mentioned above

cisagov / ScubaGoggles