search

cisagov / ScubaGoggles

SCuBA Security Configuration Baselines and assessment tool for Google Workspace
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
129 stars 13 forks source link

Refactor ReportDetails/ReportDetails OU methods #266

Open snarve opened 2 months ago

snarve commented 2 months ago

💡 Summary

Similar to the FilterEventsOU methods, the ReportDetails/ReportDetailsOUs methods have multiple instances and the one currently applied and working is for both OU and Groups. So when all OU's are complaint it displays a message 'Requirement met in all OU's and Groups'. I tried using the one for OU's only but it did not work for the report details part when one of the OU fails. We might need to refactor these methods such that we have two methods (one for pass and fail each) that works conditionally for both OU and Groups.

adhilto commented 2 months ago

Note that utils.ReportDetails is the new function that should be used in all cases now. The thing we might consider changing is for settings that can't be changed at the group level, make the message just be "Requirement met in all OUs" instead of "Requirement met in all OUs and groups," as an argument could be made that having it bring up "groups" when the setting can't be changed at the group level is confusing. Personally I'd vote for leaving it as is; even if the setting can't actually be set at the group-level, saying all groups are compliant is still technically accurate. Additionally, if some rows say "Requirement met in all OUs and groups" while others just say "Requirement met in all OUs," I could actually see that being more confusing for the user.