Add Detailed report messages for Drive&Docs

snarve commented 4 months ago

🗣 Description

Update Drive and Docs rego and unit tests to support detailed report messages and group override policy

Closes #259 Closes #282 Closes #196

💭 Motivation and context

This issue is part of the epic #190 and #90

🧪 Testing

Ensure all use cases for report and unit tests pass

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
[x] The relevant issues PR resolves are linked preferably via closing keywords.
[x] All relevant type-of-change labels have been added.
[x] I have read and agree to the CONTRIBUTING.md document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge Checklist

[x] This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
[ ] Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

[ ] Delete the branch to clean up.
[ ] Close issues resolved by this PR if the closing keywords did not activate.

LaurenBassett commented 3 months ago

It looks like the last edit requested by Alden was completed by Sheetal yesterday! Looks like it should be good to go now?

adhilto commented 3 months ago

It looks like the last edit requested by Alden was completed by Sheetal yesterday! Looks like it should be good to go now?

Unfortunately, this PR won't make it in time for this release. I only reviewed group 1. We didn't have enough time to get to the remaining groups.

LaurenBassett commented 3 months ago

It looks like the last edit requested by Alden was completed by Sheetal yesterday! Looks like it should be good to go now?

Unfortunately, this PR won't make it in time for this release. I only reviewed group 1. We didn't have enough time to get to the remaining groups.

Gotcha. All good.

buidav commented 2 months ago

@adhilto fat fingered the review button and accidentally requested your rereview.

cisagov / ScubaGoggles