The Default Safe variable was assigned an incorrect value in many of the baselines and this was resulting in incorrect conditional checks when there are no log events present for a given policy.
π§ͺ Testing
Testing may involve testing in a default setting environment (potentially new environment) where the settings/controls are unchanged and there are no log events.
Another work around to test this is to delete the logs from the 'ProviderSettingExport.json' file, that way no log events will be present and the DefaultSafe value can be tested
This update touched many of the baseline policies and corresponding unit tests, so ensure everything is working as expected
β Pre-approval checklist
[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
[x] The relevant issues PR resolves are linked preferably via closing keywords.
[x] All relevant type-of-change labels have been added.
π£ Description
Default Safe variable is incorrect in many cases
Closes #328
π Motivation and context
The Default Safe variable was assigned an incorrect value in many of the baselines and this was resulting in incorrect conditional checks when there are no log events present for a given policy.
π§ͺ Testing
Testing may involve testing in a default setting environment (potentially new environment) where the settings/controls are unchanged and there are no log events.
Another work around to test this is to delete the logs from the 'ProviderSettingExport.json' file, that way no log events will be present and the DefaultSafe value can be tested
This update touched many of the baseline policies and corresponding unit tests, so ensure everything is working as expected
β Pre-approval checklist
β Pre-merge Checklist
Squash and merge
button.β Post-merge Checklist