cisagov / XFD

CyHy Dashboard
Creative Commons Zero v1.0 Universal
8 stars 6 forks source link

Refactor Save search modal #603

Closed chrtorres closed 2 months ago

chrtorres commented 2 months ago

🗣 Description

💭 Motivation and context

Prior to this fix, save search was reliant on legacy dependency libraries. In an effort to make the application uniform and simplified, this modal has been refactored using Material UI components. Also, When a user is able to save a search, there should be some sort of check to prevent the entry of duplicate names and/or empty names. With this fix, form validation is now present to avoid invalid entries.

This resolves CRASM-629

🧪 Testing

📷 Screenshots

Save Search Modal Before

Screenshot 2024-09-11 at 10 45 40 AM

Save Search Modal Refactored

Screenshot 2024-09-11 at 10 46 16 AM

Inventory page

Screenshot 2024-09-09 at 3 04 52 PM

Saving a new search

Applying saved search

Screenshot 2024-09-09 at 3 06 59 PM

Updating a saved search

Form Validation against empty strings

Screenshot 2024-09-09 at 3 39 17 PM

Form validation against duplicate entries

Screenshot 2024-09-09 at 3 40 13 PM

✅ Pre-approval checklist

✅ Pre-merge checklist

✅ Post-merge checklist

chrtorres commented 2 months ago

As mentioned in the review. Lets get some comments regarding commented out code i.e. the plan for the deprecation of the commented code.

Comments have been added referencing the deprecated code and plans to remove in future versions.