Closed chrtorres closed 2 months ago
As mentioned in the review. Lets get some comments regarding commented out code i.e. the plan for the deprecation of the commented code.
Comments have been added referencing the deprecated code and plans to remove in future versions.
🗣 Description
💠Motivation and context
Prior to this fix, save search was reliant on legacy dependency libraries. In an effort to make the application uniform and simplified, this modal has been refactored using Material UI components. Also, When a user is able to save a search, there should be some sort of check to prevent the entry of duplicate names and/or empty names. With this fix, form validation is now present to avoid invalid entries.
This resolves CRASM-629
🧪 Testing
📷 Screenshots
Save Search Modal Before
Save Search Modal Refactored
Inventory page
Saving a new search
Applying saved search
Updating a saved search
Form Validation against empty strings
Form validation against duplicate entries
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist