Resolve Frontend CSRF/Credentials Management Findings (CRASM-730, 732) - Githubissues

cisagov / XFD

CyHy Dashboard

Creative Commons Zero v1.0 Universal

8 stars 6 forks source link

Resolve Frontend CSRF/Credentials Management Findings (CRASM-730, 732) #650

Closed hawkishpolicy closed 1 month ago

hawkishpolicy commented 1 month ago

🗣 Description

Added "noopener noreferrer" to external links detailed in ST&E Report.
Deleted RSCAuthLoginCreate.tsx, RSCRegisterForm.tsx, RSCregisterFormStyle.ts
Removed RSCAuthLoginCreate from App.tsx and the route for it.
Added placeholder text to RSCLogin.tsx with linked to-do.

💭 Motivation and context

Closes #645
Closes #659

🧪 Testing

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.