The goal was to keep Admiral running in a steady state. That end precipitated two primary changes: (1) setting a default rate limit for Celery tasks; and (2) adding timeouts to certificate requests.
💭 Motivation and context
The changes made in this PR resolve #16. Admiral no longer crashes on domains with a large number of certificates, but still struggles to process them. Admiral can be further stabilized by reducing the amount of time these queries take. I opened #20 to track work on this improvement.
🧪 Testing
With these changes in place, I could process ahrq.gov -- the domain Admiral previously crashed on. And I have continued to run Admiral since without a crash. So far, I have processed 138 domains.
✅ Pre-approval checklist
[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
🗣 Description
The goal was to keep Admiral running in a steady state. That end precipitated two primary changes: (1) setting a default rate limit for Celery tasks; and (2) adding timeouts to certificate requests.
💭 Motivation and context
The changes made in this PR resolve #16. Admiral no longer crashes on domains with a large number of certificates, but still struggles to process them. Admiral can be further stabilized by reducing the amount of time these queries take. I opened #20 to track work on this improvement.
🧪 Testing
With these changes in place, I could process
ahrq.gov-- the domain Admiral previously crashed on. And I have continued to run Admiral since without a crash. So far, I have processed 138 domains.✅ Pre-approval checklist