search

cisagov / admiral

Distributed certificate transparency log harvester
Creative Commons Zero v1.0 Universal
14 stars 3 forks source link

Crashing on save #45

Closed king-alexander closed 1 year ago

king-alexander commented 1 year ago

🐛 Summary

The admiral crashes when it attempts to save certificate records to the database.

To reproduce

Steps to reproduce the behavior:

  1. Run the load_certs script without the --dry-run option (to save records to the database)

Expected behavior

I expected certificate records to save successfully.

king-alexander commented 1 year ago

Lesson learned. It is not enough to test with a dry run. It would be beneficial to implement a test, say in cisagov/admiral-docker#6, that attempts to save certificate records to a mock database.