Update mongo tests - Githubissues

cisagov / admiral

Distributed certificate transparency log harvester

Creative Commons Zero v1.0 Universal

14 stars 3 forks source link

Update mongo tests #47

Closed king-alexander closed 1 year ago

king-alexander commented 1 year ago

🗣 Description

These changes update tests that connect to a mock Mongo database.

💭 Motivation and context

Closes #50

🧪 Testing

I modified the tests that connect to a mock Mongo database to use the new connection method. After my changes, all tests passed locally.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[x] Revert dependencies to default branches.
[x] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

dav3r commented 1 year ago

These changes look good to me, but I'll wait for the GH Actions checks to pass before actually approving.

Yes, please let us know when the GH Actions all pass and then we will finalize our reviews.

king-alexander commented 1 year ago

I will add a test to boost coverage and make the Coveralls check happy.