Update CT Search request

king-alexander commented 1 year ago

🗣 Description

I updated the CT Search API request to expand the new cert_der field.

💭 Motivation and context

According to the SSLMate Changelog, on January 3rd 2023 the cert object was deprecated. You now use cert_der to retrieve certificate data.

Resolves #51

🧪 Testing

I verified that our tasks still function as expected with the changes in place. To test, I performed a dry run and monitored progress from the Celery Flower dashboard. The summary_by_domain task returned results with cert_der expanded, and the cert_by_issuance task returned the base64 representation of the DER-encoded certificate. I stopped the dry run after approximately 10 domains had been scanned.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[x] Revert dependencies to default branches.
[x] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

Note: A v.1.3.4 release will not be built for these changes because the version is semantically incorrect. The v1.3.3 release targets a fix at 3cfcde5.

jsf9k commented 1 year ago

@king-alexander - The linter failure should go away once the current Kraken flows down to this repository.

dav3r commented 1 year ago

@king-alexander You should mention something in this PR about why version 1.3.4 will not be built after this PR was merged.

cisagov / admiral