Get rid of include warnings - Githubissues

cisagov / ansible-role-amazon-ssm-agent

An Ansible role for installing aws/amazon-ssm-agent

Creative Commons Zero v1.0 Universal

8 stars 4 forks source link

Get rid of include warnings #43

Closed jsf9k closed 1 year ago

jsf9k commented 1 year ago

🗣 Description

This pull request:

Gets rid of a simple include directive, which is now deprecated, in favor of an ansible.builtin.include_tasks directive
Modifies the Ansible code to use FQCNs throughout
Alphabetizes a few module parameters where necessary
Adds @mcdonnnj as a codeowner

💭 Motivation and context

This gets rid of an annoying deprecation warning in our Packer AMI builds, and prevents future breakage.
FQCNs have been preferred by Ansible for some time now. I'm not sure how this repository missed the grand cleanup we went through several Krakens ago.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.