cisagov / ansible-role-guacamole

An Ansible role for installing cisagov/guacamole-composition
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

Add guacscanner #38

Closed jsf9k closed 2 years ago

jsf9k commented 2 years ago

🗣 Description

This pull request modifies this Ansible role to allow for the addition of cisagov/guacscanner-docker to cisagov/guacamole-composition.

💭 Motivation and context

The functionality of cisagov/guacscanner-docker is necessary for the RPT UAT taking place in the COOL.

See also:

🧪 Testing

I have applied these changes to env0 in our staging COOL environment and verified that they function as expected.

✅ Checklist

jsf9k commented 2 years ago

I also went a bit too far down the rabbit hole and found that the Dockerfile for guacamole/guacamole is installing a PostgreSQL JDBC driver that's over six years old. We should probably make an issue in the Apache JIRA to either fix it ourselves with a PR or at least get some attention on it I guess. The closest issue I could find was someone else having a problem in GUACAMOLE-1433 and another user mentions the JDBC driver needing an update.

Good idea. The old driver has already bitten us. See cisagov/guacamole-composition@8197d0e804a145a8dac67078b1e0a14c68e8e99d for more details.