Closed mcdonnnj closed 2 years ago
This PR adds support for the new version of cisagov/guacscanner and updates the tasks to install a specific version of cisagov/guacscanner.
With the changes in https://github.com/cisagov/guacscanner/pull/16 to connect to Windows instances using VNC there needs to be an additional secret for the Dockerized container version of cisagov/guacscanner. Additionally we specify the version of the Dockerized container version to install to avoid unsupported changes to a latest version from being unintentionally installed.
latest
Automated tests work. I generated a new AMI using this branch and everything installed and worked as expected.
develop
๐ฃ Description
This PR adds support for the new version of cisagov/guacscanner and updates the tasks to install a specific version of cisagov/guacscanner.
๐ญ Motivation and context
With the changes in https://github.com/cisagov/guacscanner/pull/16 to connect to Windows instances using VNC there needs to be an additional secret for the Dockerized container version of cisagov/guacscanner. Additionally we specify the version of the Dockerized container version to install to avoid unsupported changes to a
latest
version from being unintentionally installed.๐งช Testing
Automated tests work. I generated a new AMI using this branch and everything installed and worked as expected.
โ Pre-approval checklist
โ Pre-merge checklist
develop
branch for pulling cisagov/guacamole-composition