cisagov / ansible-role-openvpn

Ansible role to install an OpenVPN server and configure it to authenticate users certificates against FreeIPA.
Creative Commons Zero v1.0 Universal
8 stars 2 forks source link

Fix Ubuntu 18.04 molecule failures #37

Closed jsf9k closed 3 years ago

jsf9k commented 3 years ago

๐Ÿ—ฃ Description

This pull request adds the netbase package for Ubuntu, which fixes a reproducible error in the converge state of molecule for Ubuntu 18.04. The geerlingguy/docker-ubuntu1804-ansible:latest Docker image is suddenly missing this package, perhaps due to an omission in its base image.

This pull request also cleans up a few files, removing some now-unnecessary cruft.

๐Ÿ’ญ Motivation and Context

The molecule tests have been reproducibly failing for this repository lately, and this PR fixes that.

This PR resolves (partially) #30.

๐Ÿงช Testing

All pre-commit hooks and molecule tests pass.

โœ… Checklist

jsf9k commented 3 years ago

Did you mention anything about this to geerlingguy?

I think the netbase package is missing from the upstream Docker image, and therefore outside his control, but I'll mention @geerlingguy here so he knows.