Limit usage of the `--break-system-packages` flag

mcdonnnj commented 1 year ago

🗣 Description

Thie pull request adjusts the logic for adding the --break-system-packages flag as an extra argument to only occur on Debian Bookworm and Kali Linux systems.

💭 Motivation and context

This flag requires pip 23.0.1 to function. This version of pip is only available as a system package on Debian 12 (Bookworm) and Kali LInux (which is currently based on Debian Bookworm). The Docker images we use for testing upgrade the pip package outside of the system package offered and so although tests pass the role will fail if run on a non-Debian Bookworm or Kali LInux system as seen here. This is the same issue as in https://github.com/cisagov/ansible-role-pca-gophish-composition/pull/43.

🧪 Testing

Automated tests pass. I also created a testing branch of cisagov/openvpn-packer using this branch and the test machine image was able to build successfully as seen here.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

dav3r commented 1 year ago

What's going on with this test failure? Is that the same the sporadic error that we have seen in the past and we just need to re-run the test job?

mcdonnnj commented 1 year ago

What's going on with this test failure? Is that the same the sporadic error that we have seen in the past and we just need to re-run the test job?

Yes it looks that way.

cisagov / ansible-role-openvpn