cisagov / cool-dns-cyber.dhs.gov

Terraform configuration to create and populate the cyber.dhs.gov zone.
Creative Commons Zero v1.0 Universal
3 stars 9 forks source link

Add additional permissions needed for hosted zone lookup by name #10

Closed dav3r closed 4 years ago

dav3r commented 4 years ago

๐Ÿ—ฃ Description

This PR adds additional permissions that are needed when looking up the hosted zone by name.

๐Ÿ’ญ Motivation and Context

This PR was needed due to the changes in https://github.com/cisagov/pca-teamserver-aws/pull/30.

๐Ÿงช Testing

terraform apply was executed successfully in the production workspace. Then, the code from https://github.com/cisagov/pca-teamserver-aws/pull/30 was used to successfully add a DNS record in this zone.

๐Ÿ“ท Screenshots (if appropriate)

๐Ÿšฅ Types of Changes

โœ… Checklist

felddy commented 4 years ago

Also I believe I clobbered your policy changes with my ongoing work to get SES domain and DKIM records fixed:

https://github.com/cisagov/cool-dns-cyber.dhs.gov/tree/bugfix/amazonses-dmarc-txt

jsf9k commented 4 years ago

Also I believe I clobbered your policy changes with my ongoing work to get SES domain and DKIM records fixed:

You just pulled a Dennis Brake!

jsf9k commented 4 years ago

Please use the output of this module to get the hosted zone.

See this comment from @jsf9k 's PR 5 days ago: #8 (comment)

I don't know how I feel about sharing state with projects that are unrelated to the COOL. Feels like we need more social distancing.

felddy commented 4 years ago

If it's in the cloud it's in the COOLโ„ข.

dav3r commented 4 years ago

With the latest changes in https://github.com/cisagov/pca-teamserver-aws/pull/30 (mainly https://github.com/cisagov/pca-teamserver-aws/pull/30/commits/a0ebe15d5e731e262f889f7ce04961f70632e772), this PR is no longer necessary, so I am closing it out.