Add Crossfeed integration and api.integration records (A, AAAA, TXT, CAA)

cisagov / cool-dns-cyber.dhs.gov

Terraform configuration to create and populate the cyber.dhs.gov zone.

Creative Commons Zero v1.0 Universal

3 stars 9 forks source link

Add Crossfeed integration and api.integration records (A, AAAA, TXT, CAA) #113

Closed cduhn17 closed 2 weeks ago

cduhn17 commented 2 weeks ago

Update domain name for integration

🗣 Description

We need to add the api.integration domain name and issue letsencrypt ssl certificates. There is a need for both a TXT record and CAA record and adding AAAA and A records for integration.

💭 Motivation and context

There are no existing ACME certs

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[x] All new and existing tests pass.

cduhn17 commented 2 weeks ago

@dav3r , I have some code commented out that will be a follow-on PR, I have this commented out because I have to have the SSL cert in place before I can get the values from AWS for the AAAA and A records for api.integration.crossfeed.cyber.dhs.gov

dav3r commented 2 weeks ago

@dav3r , I have some code commented out that will be a follow-on PR, I have this commented out because I have to have the SSL cert in place before I can get the values from AWS for the AAAA and A records for api.integration.crossfeed.cyber.dhs.gov

Please remove the commented-out code since it's not relevant to this PR - it should be added in your next PR.

jsf9k commented 2 weeks ago

@cduhn17 - When you make a change please ensure that the commit message speaks to the change that was made. "Update route53_crossfeed_app.tf" is very generic and tells a future developer nothing about the content of the commit.

cduhn17 commented 2 weeks ago

@dav3r am I GTG after a tf apply? Thanks

cduhn17 commented 2 weeks ago

@dav3r My intent with the commented out code was that the code will be added right after this PR is applied. But i removed it for now. Thanks

dav3r commented 2 weeks ago

@dav3r My intent with the commented out code was that the code will be added right after this PR is applied. But i removed it for now. Thanks

Sorry, that wasn't clear before - I thought you meant that code was going to be added in a subsequent PR.

cduhn17 commented 2 weeks ago

Let me know when i can try the verification. Thanks

dav3r commented 2 weeks ago

Let me know when i can try the verification. Thanks

The changes have been applied - give it a shot.

cduhn17 commented 2 weeks ago

Thanks all i have the certificates in hand

dav3r commented 2 weeks ago

@cduhn17 I applied the current Terraform and created the integration API A and AAA records. Please let me know if there is anything else planned in this PR.

cduhn17 commented 2 weeks ago

@dav3r , Thanks for all of your help. There is nothing further for this PR