Add Crossfeed entries - Githubissues

cisagov / cool-dns-cyber.dhs.gov

Terraform configuration to create and populate the cyber.dhs.gov zone.

Creative Commons Zero v1.0 Universal

3 stars 9 forks source link

Add Crossfeed entries #20

Closed hillaryj closed 4 years ago

hillaryj commented 4 years ago

Adds manually-created Crossfeed entries for prod and staging instances to Terraform.

🗣 Description

💭 Motivation and Context

Simplifies change management.
Closes https://github.com/cisagov/cool-dns-cyber.dhs.gov/issues/17.

🧪 Testing

Both terraform validate and pre-commit pass.

📷 Screenshots (if appropriate)

🚥 Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

jsf9k commented 4 years ago

At first blush, these records appear correct to me. Have you tried terraform importing the records you created manually and verifying that terraform apply (or terraform plan) doesn't want to make changes? I can walk you through that for one or two of the records this afternoon if you want.