Add permission to allow searching for cyber.dhs.gov hosted zone ID

jsf9k commented 4 years ago

🗣 Description

In this pull request I add two permissions to the Route53ResourceChange-cyber.dhs.gov role that allows users to search for the cyber.dhs.gov hosted zone.

💭 Motivation and Context

These extra permissions are required, for example, in cisagov/openvpn-server-tf-module.

🧪 Testing

I deployed these changes to COOL production and used them to deploy cisagov/openvpn-server-tf-module to COOL staging.

🚥 Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

felddy commented 4 years ago

Does it make sense to be setting a var for the domain, then searching for it, when you could just pull in the zone (cyber_dhs_gov_zone) from the output of this module: https://github.com/cisagov/cool-dns-cyber.dhs.gov/blob/4ea955350ba257486ac6ba19d426f80b9a6c9ee9/outputs.tf#L1-L4

This was my intended use pattern for DNS in the COOL.

jsf9k commented 4 years ago

I will rework to use remote state.

On Thu, Mar 26, 2020 at 9:01 AM Mark Feldhousen notifications@github.com wrote:

Does it make sense to be setting a var for the domain, then searching for it, when you could just pull in the zone (cyber_dhs_gov_zone) from the output of this module:

https://github.com/cisagov/cool-dns-cyber.dhs.gov/blob/4ea955350ba257486ac6ba19d426f80b9a6c9ee9/outputs.tf#L1-L4

This was my intended use pattern for DNS in the COOL.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/cisagov/cool-dns-cyber.dhs.gov/pull/8#issuecomment-604417716, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKECPMAQG7VW4HSRP4SWUDRJNG3JANCNFSM4LT45TPA .

jsf9k commented 4 years ago

In deference to @felddy's comment, I resolved this a different way. See cisagov/cool-sharedservices-openvpn#10 and cisagov/openvpn-server-tf-module#19.

cisagov / cool-dns-cyber.dhs.gov