Closed aloftus23 closed 1 year ago
@dav3r This is a time sensitive push. If you can review at your earliest convenience that would be greatly appreciated.
@aloftus23 - I went ahead and applied these changes to our production COOL instance, so your DNS records should already be out there.
Great thanks for the quick review. We will test now.
@aloftus23 - Please read the checkbox items carefully before clicking them. You clicked several that don't apply to this PR, and you had clicked the one for "all relevant labels have been selected" even though you hadn't selected a single label.
I went ahead and made the necessary corrections for you.
@aloftus23 - Please read the checkbox items carefully before clicking them. You clicked several that don't apply to this PR, and you had clicked the one for "all relevant labels have been selected" even though you hadn't selected a single label.
I went ahead and made the necessary corrections for you.
My bad. Noted for next time.
@aloftus23 - I went ahead and applied these changes to our production COOL instance, so your DNS records should already be out there.
Great thanks for the quick review. We will test now.
Let us know how the tests go. If they are successful then I will merge this PR.
@aloftus23 - Any update on the results of your testing?
@aloftus - Any update on the testing results?
The certs were uploaded yesterday so just confirmed there are good and tested.
Huzzah! I'll go ahead and merge then.
๐ฃ Description
We need to update the TXT record for the DNS to create a certificate for Let'sEncrypt. terraform-docs has been run.
Updated the existing api.staging.cyber.dhs.gov, but had to add the record for staging.crossfeed.cyber.dhs.gov (I believe this was deleted in a previous PR)
๐ญ Motivation and context
The original Crossfeed Staging Certs expired, and this will allow us to recreate them.
๐งช Testing
Ran terraform-docs to see if any changes were made to the docs
โ Pre-approval checklist