cisagov / cool-dns-cyber.dhs.gov

Terraform configuration to create and populate the cyber.dhs.gov zone.
Creative Commons Zero v1.0 Universal
3 stars 9 forks source link

Update Crossfeed TXT records for acme #86

Closed aloftus23 closed 1 year ago

aloftus23 commented 1 year ago

๐Ÿ—ฃ Description

We need to update the TXT record for the DNS to create a certificate for Let'sEncrypt. terraform-docs has been run.

Updated the existing api.staging.cyber.dhs.gov, but had to add the record for staging.crossfeed.cyber.dhs.gov (I believe this was deleted in a previous PR)

๐Ÿ’ญ Motivation and context

The original Crossfeed Staging Certs expired, and this will allow us to recreate them.

๐Ÿงช Testing

Ran terraform-docs to see if any changes were made to the docs

โœ… Pre-approval checklist

aloftus23 commented 1 year ago

@dav3r This is a time sensitive push. If you can review at your earliest convenience that would be greatly appreciated.

aloftus23 commented 1 year ago

@aloftus23 - I went ahead and applied these changes to our production COOL instance, so your DNS records should already be out there.

Great thanks for the quick review. We will test now.

jsf9k commented 1 year ago

@aloftus23 - Please read the checkbox items carefully before clicking them. You clicked several that don't apply to this PR, and you had clicked the one for "all relevant labels have been selected" even though you hadn't selected a single label.

I went ahead and made the necessary corrections for you.

aloftus23 commented 1 year ago

@aloftus23 - Please read the checkbox items carefully before clicking them. You clicked several that don't apply to this PR, and you had clicked the one for "all relevant labels have been selected" even though you hadn't selected a single label.

I went ahead and made the necessary corrections for you.

My bad. Noted for next time.

jsf9k commented 1 year ago

@aloftus23 - I went ahead and applied these changes to our production COOL instance, so your DNS records should already be out there.

Great thanks for the quick review. We will test now.

Let us know how the tests go. If they are successful then I will merge this PR.

jsf9k commented 1 year ago

@aloftus23 - Any update on the results of your testing?

jsf9k commented 1 year ago

@aloftus - Any update on the testing results?

aloftus23 commented 1 year ago

The certs were uploaded yesterday so just confirmed there are good and tested.

jsf9k commented 1 year ago

Huzzah! I'll go ahead and merge then.