cisagov / cool-images-assessment-images

Terraform code to create resources to provide storage and access for assessment images in the COOL.
Creative Commons Zero v1.0 Universal
2 stars 1 forks source link

Add Read Access for Users on the COOL VPN #4

Closed mcdonnnj closed 3 years ago

mcdonnnj commented 3 years ago

🗣 Description

This PR adds a bucket policy to permit read access for anyone accessing the bucket over the COOL VPN (through the SharedServices VPC).

💭 Motivation and context

This is the last piece of https://github.com/cisagov/cool-system/issues/176 and will allow any COOL users to retrieve assessment images over the VPN.

🧪 Testing

First I confirmed that without assuming the AssessmentImagesBucketFullAccess role I could not access the bucket contents when on the VPN. Once the changes in https://github.com/cisagov/cool-sharedservices-networking/pull/47 were applied I was able to apply the Terraform here to add the bucket policy. I manually added the appropriate routes to the S3 service to my VPN configuration and connected. Once connected I was able to confirm the ability to list the bucket contents and get an object. I also confirmed that I could not put an object.

✅ Checklist