cisagov / crossfeed

External monitoring for organization assets
https://docs.crossfeed.cyber.dhs.gov
Creative Commons Zero v1.0 Universal
364 stars 54 forks source link

GENERATE REPORT from Overview (Dashboard) feature never completes. #2451

Open dmfezzareed opened 8 months ago

dmfezzareed commented 8 months ago

🐛 Summary

When a standard user, or GlobalAdmin user attempts to GENERATE REPORT the process gives the appearance of "processing" that never ends.

To reproduce

Steps to reproduce the behavior:

  1. Log into Crossfeed
  2. Permit dashboard to load. If a dashboard does not load, you may need to add yourself to several organizations and then reload the dashboard.
  3. Click "GENERATE REPORT"
  4. Then wait to see if a download file is generated. If left alone, and you permit the browser window to remain open, it will look like the process is still running in the morning (not good).
  5. CNTL+F5 will stop the process.

Expected behavior

When a user clicks GENERATE REPORT the process may run for a while, no more than 10 -15 minutes max, and should then generate a csv download file much like the user or organization export function does.

Any helpful log output or screenshots

GENERATE REPORT behavior with DevTools: https://github.com/cisagov/crossfeed/assets/33070478/131da44d-fe6a-4ea7-ae98-932d0e2961a4

Potentially related issue: https://github.com/cisagov/crossfeed/issues/1963

dmfezzareed commented 8 months ago

@schmelz21 this issue is time-sensitive and must be resolved before the new database goes live. Once the new database is live, the data consumer will have every right to expect to be able to report their data.

cc @stewartl97

Matthew-Grayson commented 7 months ago

I confirmed that the Generate Report function works in Safari and is broken when using Firefox or Chrome on MacOS. For these two browsers, the dev console displays Error (Incomplete or corrupt png file). I addressed this error using the fix suggested here. The Generate Report function now appears to create a report and the loading icon disappears when the function completes. However the report is not downloaded.

dmfezzareed commented 7 months ago

Matthew, When I attempt to Generate Report from a Windows 11 laptop, and a Chrome browser, it gives the appearance the report is running and never stops. It did work prior to the move from commercial to govcloud.

With Thanks and Best Regards, Debra

From: Matthew @.> Sent: Tuesday, January 30, 2024 11:32 To: cisagov/crossfeed @.> Cc: Fezza Reed, Debra M @.>; Assign @.> Subject: Re: [cisagov/crossfeed] GENERATE REPORT from Overview (Dashboard) never completes. (Issue #2451)

CAUTION: This email originated from outside of DHS. DO NOT click links or open attachments unless you recognize and/or trust the sender. Contact your component SOC with questions or concerns.

I confirmed that the Generate Report function works in Safari and is broken when using Firefox or Chrome on MacOS. For these two browsers, the dev console displays Error (Incomplete or corrupt png file). I addressed this error using the fix suggested herehttps://urldefense.us/v3/__https:/stackoverflow.com/a/71937917/18756542__;!!BClRuOV5cvtbuNI!GxKE1K7g2pkcqQlV03FNY4AiHDV-wZHLZkKgpdq1EAQdTEMEPs7t55NYjzaLaKIm8xsHAAGcn3lmhTM-sxfB8MS5NHlA4znMBIQ$. The Generate Report function now appears to create a report and the loading icon disappears when the function completes. However the report is not downloaded.

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/cisagov/crossfeed/issues/2451*issuecomment-1917745178__;Iw!!BClRuOV5cvtbuNI!GxKE1K7g2pkcqQlV03FNY4AiHDV-wZHLZkKgpdq1EAQdTEMEPs7t55NYjzaLaKIm8xsHAAGcn3lmhTM-sxfB8MS5NHlAqacsaxY$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/AH4J3DU66YPMXGBBN65J763YRFDCDAVCNFSM6AAAAABBSGSWLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXG42DKMJXHA__;!!BClRuOV5cvtbuNI!GxKE1K7g2pkcqQlV03FNY4AiHDV-wZHLZkKgpdq1EAQdTEMEPs7t55NYjzaLaKIm8xsHAAGcn3lmhTM-sxfB8MS5NHlAeEcnMuI$. You are receiving this because you were assigned.Message ID: @.***>

schmelz21 commented 7 months ago

Placed on hold, for a reevaluation of implimentation steps.

schmelz21 commented 7 months ago

It was determined to remove this button and functionality to be redesigned. @Matthew-Grayson can you hide/remove this button.