search

cisagov / crossfeed

External monitoring for organization assets
https://docs.crossfeed.cyber.dhs.gov
Creative Commons Zero v1.0 Universal
364 stars 54 forks source link

Convert Registration Email Template from S3 to Static #2508

Closed nickviola closed 6 months ago

nickviola commented 7 months ago

💡 Summary

Remove S3 Storage/Logic from the User Registration HTML email template creation. We will be converting this to local asset storage and reference in the backend api source.

Motivation and context

It has been determined by leadership that S3 storage for email template creation would cause some complexities and concerns in the future.

Implementation notes

Converting logic to local image/asset path reference and will be testing functionality in the DMZ

Acceptance criteria

schmelz21 commented 6 months ago

@nickviola - can I now delete the S3 bucket that was created?

nickviola commented 6 months ago

Merged #2509, just need to test and confirm html email output before closing this issue.

schmelz21 commented 6 months ago

OBE - A change in scope occured. All conent to be manages separately from the code. Revert back to S3 html template logic in registration email process