cisagov / crossfeed

External monitoring for organization assets
https://docs.crossfeed.cyber.dhs.gov
Creative Commons Zero v1.0 Universal
359 stars 54 forks source link

Wrong email sent on new User approval. #2529

Closed schmelz21 closed 4 months ago

schmelz21 commented 5 months ago

🐛 Summary

During the new user registration process a series of emails are sent to operate the onboarding process. One of the emails being sent is out sync to the process. The "Account Creation" email is being sent when "Account Approved" email should be sent when the regional admin adds the User to an organization. This is a significant bug, as the content of "Account Approved" contains a link for the User to set up MFA and account password.

To reproduce

Steps to reproduce the behavior:

  1. Register for an Account
  2. Have the Regional Admin approve the account
  3. Upon approval, you can see the wrong email sent to the User's inbox which reads, "Account Creation", "Your request to create an account with Crossfeed has been received. After approval from your Regional Manager, you will receive another email with your approval status and further steps."

Expected behavior

"Account Approved" email should be sent with link to MFA and password creation step.