cisagov / crossfeed

External monitoring for organization assets
https://docs.crossfeed.cyber.dhs.gov
Creative Commons Zero v1.0 Universal
359 stars 54 forks source link

Change location of footer component from app.tsx to layout.tsx to correctly position footer Fixes #2545 #2557

Closed lfilip-ivaal closed 5 months ago

lfilip-ivaal commented 5 months ago

πŸ—£ Description

πŸ’­ Motivation and context

General UX change to not have the footer float up near the top if there wasn't enough content to push it to the bottom.

πŸ§ͺ Testing

Manual testing.

βœ… Pre-approval checklist

βœ… Pre-merge checklist

βœ… Post-merge checklist

lfilip-ivaal commented 5 months ago

@lfilip-ivaal - there are test failures in this PR. Can you see if you can clean up those before we merge.

Looked into this and I needed to update the snapshot since the footer technically moved to a different location within the file structure.