cisagov / cyhy-core

Core code for Cyber Hygiene (CyHy)
Other
8 stars 10 forks source link

Allow for more than two POCs in the cyhy-simple script #37

Closed jsf9k closed 4 years ago

jsf9k commented 4 years ago

This is in response to a request from @climber-girl, who tires of manually adding extra POCs to the request JSON after running cyhy-simple. This simple change will save the CyHy team a lot of time and suffering.

I recommend viewing the commits separately when reviewing. The commit a3ef3d2 contains the actual code changes I made, while the commit 275a22f contains the changes made by the Python code linter black.

(I went ahead and blackened the cyhy-simple script like a piece of redfish, since that will make @felddy's upcoming merge of #36 slightly simpler.)

jsf9k commented 4 years ago

Please note that Paul Prudhomme and Dom Deluise are not the same person. This is a debunked conspiracy theory being maliciously spread by @felddy.

felddy commented 4 years ago

https://www.thedailymeal.com/eat/10-things-you-didnt-know-about-paul-prudhomme-0/slide-5

DeLuise, who died in 2009, claimed to have once successfully impersonated Prudhomme at K-Paul's.

jsf9k commented 4 years ago

https://www.thedailymeal.com/eat/10-things-you-didnt-know-about-paul-prudhomme-0/slide-5

DeLuise, who died in 2009, claimed to have once successfully impersonated Prudhomme at K-Paul's.

Ha, I didn't know that!

jsf9k commented 4 years ago

Upon discussion with @climber-girl, it was decided that the most desirable behavior is to by default reject INI files that either:

However, both these behaviors can be overridden with the --force command line option.

This change was made in commit 87ca299.