This PR fixes a bug in the error handling code of the check_restricted_ip() function.
💠Motivation and context
This bug prevents us from being able to add IPs that don't exist in our geoIP DB.
Resolves #92.
🧪 Testing
I tested the changes to geoloc.py in my development environment by:
Running the cyhy-ip command below against IP addresses that don't exist in the geoIP DB
Comparing the results against past results; verifying the correct results
Running the cyhy-ip command below against other IP addresses and CIDRs to assure the results provided the expected results
Expected results verified:
cyhy-ip add TEST_ENTITY <IP address>
IPs added to request, and initialized. Tally sync required to start scan of new IPs.▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶▶| ETA: 0:00:00
✅ Pre-approval checklist
[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
🗣 Description
This PR fixes a bug in the error handling code of the
check_restricted_ip()
function.💠Motivation and context
This bug prevents us from being able to add IPs that don't exist in our geoIP DB.
Resolves #92.
🧪 Testing
I tested the changes to
geoloc.py
in my development environment by:cyhy-ip
command below against IP addresses that don't exist in the geoIP DBcyhy-ip
command below against other IP addresses and CIDRs to assure the results provided the expected resultsExpected results verified:
✅ Pre-approval checklist
✅ Post-merge checklist