This pull request modifies the upgrade.yml Ansible playbook used in the Packer configurations in this project. It converts the use of roles to a list of tasks so that we can more directly reflect what is being done with each role and flexibility in the playbook.
💠Motivation and context
Rather than having to document why the list of roles is not in alphabetical order I think it is cleaner to just convert them to tasks in the desired order. This also allows us to give a name to describe what each role is being used to do and opens up more flexibility to intermingle other tasks.
🧪 Testing
Automated tests pass. I built and deployed new AMIs using this change with no issues. I also verified that the backports SourceList is being updated on systems that do not use DEB822 formatted SourceList files (please see https://github.com/cisagov/ansible-role-apt-over-https/issues/25 for why I only checked these files).
✅ Pre-approval checklist
[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
🗣 Description
This pull request modifies the
upgrade.ymlAnsible playbook used in the Packer configurations in this project. It converts the use ofrolesto a list oftasksso that we can more directly reflect what is being done with each role and flexibility in the playbook.💠Motivation and context
Rather than having to document why the list of
rolesis not in alphabetical order I think it is cleaner to just convert them totasksin the desired order. This also allows us to give anameto describe what each role is being used to do and opens up more flexibility to intermingle other tasks.🧪 Testing
Automated tests pass. I built and deployed new AMIs using this change with no issues. I also verified that the backports SourceList is being updated on systems that do not use DEB822 formatted SourceList files (please see https://github.com/cisagov/ansible-role-apt-over-https/issues/25 for why I only checked these files).
✅ Pre-approval checklist