Closed kristinacyin closed 2 months ago
@kristinacyin The title of the PR says "updated broken links" but I don't see any changed links.
Also, I don't think "verification" should be plural ... can you say a bit more about this update?
@kristinacyin The title of the PR says "updated broken links" but I don't see any changed links.
Also, I don't think "verification" should be plural ... can you say a bit more about this update?
Oh this was just a random PR I made to show Christina the process of how PRs work - please ignore
@kristinacyin should we close this PR?
Yes, for some reason I thought it was already closed 😅 @h-m-f-t @Katherine-Osos
Ticket
Resolves #34
Changes
Context for reviewers
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
[ ] New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
[ ] Checked keyboard navigability
[ ] Meets all designs and user flows provided by design/product
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
[ ] Checked keyboard navigability
[ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
[ ] Tested with multiple browsers (check off which ones were used)
[ ] (Rarely needed) Tested as both an analyst and applicant user
Screenshots