cisagov / get.gov

The website for the .gov registry
https://get.gov
Other
15 stars 2 forks source link

Issue #250: Use info alert instead of summary box for featured domain #278

Closed rachidatecs closed 5 months ago

rachidatecs commented 5 months ago

Ticket

Resolves #250

Changes

Context for reviewers

Per USWDS guidance:

Alerts or callouts. you’re highlighting something new, rather than surfacing details from further down the page, use the alert component, such as the informative status alert.

I didn't mess with the alert--info styling at all. @cisagov/gov-designers, if you want me to match the old summary box color and border just say so, piece of cake.

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Ensured code standards are met (Original Developer)

Validated user-facing changes (if applicable)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Ensured code standards are met (Code reviewer)

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist

As a designer reviewer, I have

Verified that the changes match the design intention

Validated user-facing changes as a designer

Screenshots

Screenshot 2024-04-26 at 4 01 28 PM

gabydisarli commented 5 months ago

@rachidatecs can we match the styling from the summary box?

gabydisarli commented 5 months ago

Everything looks great. One small update please: on mobile can we add some padding between the more blog posts link and the featured .gov section so they don’t sit right on top of each other?

IMG_1362

michelle-rago commented 5 months ago

yay!