cisagov / gophish-tools

Helpful tools for interacting with a GoPhish phishing instance
Creative Commons Zero v1.0 Universal
42 stars 6 forks source link

Change String logging from f-strings to printf style. #34

Closed JCantu248 closed 2 years ago

JCantu248 commented 3 years ago

💡 Summary

Go through the gophish-tools repository and change the f-string style logging messages to printf style messages.

Motivation and context

Logging messages may not be properly evaluated if the message formatting arguments contain a log level that is lower than the logger's log level. To avoid this issue, switch all logging messages to using the %-formatting style.

See here for details

Implementation notes

Acceptance criteria

How do we know when this work is done?

JCantu248 commented 2 years ago

Closing issue as it was resolved by https://github.com/cisagov/gophish-tools/pull/46