cisagov / gophish-tools

Helpful tools for interacting with a GoPhish phishing instance
Creative Commons Zero v1.0 Universal
42 stars 6 forks source link

Remove Auto Appended Campaign Identifier During Creation #43

Closed nickviola closed 3 years ago

nickviola commented 3 years ago

💡 Summary

We currently append a campaign identifier to newly created campaigns in GoPhish. This appends -C1, -C2, etc. to the assessment name. We are modifying how we reference these assessments and this is no longer required. Remove the logic that appends this "-CX" identifier.

Motivation and context

The way we will be referencing and naming campaigns will be changing and this is no longer needed.

Implementation notes

Remove the logic that appends the id here: https://github.com/cisagov/gophish-tools/blob/c0e7d586815dfe867b07caa7838fbbdb31d8a250/src/assessment/builder.py#L152

Ensure the -CX id is no longer added during the setup process.

Acceptance criteria

New campaigns no longer have a "-CX" identifier appended to the name. To test, schedule a new campaign and verify name output upon successful creation.