Update assessment builder confirmation prompts

nickviola commented 3 years ago

🗣 Description

Updated the wording for confirmation prompts in the current gophish-tools assessment builder logic. While making this change, it was also a good time to convert the prompt string value (previously hard coded in multiple places) to a "constant" that's a single touch point in the future. I also updated and added punctuation and minor formatting fixes I noticed to clean things up a bit.

💭 Motivation and context

The feedback from our recent demos and testing proved that the previous prompt confirmation was a bit confusing in how it was presented to the user. As a group, we decided to change the wording to reduce confusion in the future. The other small cleanup items just made sense to address while working there and able to do complete quickly.

🧪 Testing

Made changes to prompt values and rebuilt and ran the setup process to confirm the values and wording was correct. Screen capture of the resulting test is included below.

📷 Screenshots (if appropriate)

https://user-images.githubusercontent.com/6486652/135345441-f3942251-31ad-4e94-9b1e-ba993b2703ab.mov

✅ Checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.

nickviola commented 3 years ago

Thanks for incorporating my feedback - this looks solid now! 🦖

Thanks for the feedback and quick responses on this!!

nickviola commented 3 years ago

If everyone is good with these changes, green light on this end to merge in as you have the time. Thanks for everyone's time reviewing and providing input here.

cisagov / gophish-tools